Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Image pull secrets not set on sync util pod causing Dockerhub rate limiting #6525

Closed
eysi09 opened this issue Oct 8, 2024 · 0 comments · Fixed by #6530
Closed

[Bug]: Image pull secrets not set on sync util pod causing Dockerhub rate limiting #6525

eysi09 opened this issue Oct 8, 2024 · 0 comments · Fixed by #6530
Assignees
Labels

Comments

@eysi09
Copy link
Collaborator

eysi09 commented Oct 8, 2024

Bug

Current behavior

Due to #5336, users can get rate limited when pulling Garden images from our public Dockerhub repo if they haven't added an image pull secret with their Docker credentials to their cluster. Admittedly they shouldn't need that in the first place and we are applying for the "Docker Verified Publisher" program which should fix this.

Adding the secret fixes the issue for some of the util pods but not for the sync pod because the image pull secrets aren't set in its manifest.

We need to fix that for now, although again, if/when we're a verified publisher it shouldn't be needed in the first place.

Expected behavior

Creating the sync util pod shouldn't fail with a Dockerhub rate limit error if the user already has created image pull secrets and specified in the Garden config (under the K8s provider imagePullSecrets field).

Reproducible example

N/A

Workaround

N/A

Suggested solution(s)

We should set the imagePullSecrets on the sync util Deployment like we e.g. do for the buildkit Deployment here: https://github.com/garden-io/garden/blob/main/core/src/plugins/kubernetes/container/build/buildkit.ts#L218

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants