fix(core): avoid crash when using copyFrom together with symlinks
#6485
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stefreak
commented
Sep 25, 2024
| // If target is a directory or source is a symbolic link and deletes are allowed, delete the target before copying, otherwise throw | ||
| if (toStats.isDirectory() || fromStats.isSymbolicLink()) { | ||
| // If target is a directory and deletes are allowed, delete the target before copying, otherwise throw | ||
| if (toStats.isDirectory()) { |
There was a problem hiding this comment.
this change caused the regression. If target is a symbolic link, we must overwrite it even if allowDelete is false.
- Do not ignore symlinks whose target does not exist. These symlinks are perfectly valid. - Ignore relative symlinks that point outside of the repository, even if they do not start with ..
vvagaytsev
approved these changes
Sep 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This commit resolves an error "Failed copying a file because a directory
exists at the target path" which was a regression introduced in #6430.
Which issue(s) this PR fixes:
Fixes #6456