Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Opentelemetry missing span when using "-o yaml" option #6482

Closed
har-cpol opened this issue Sep 25, 2024 · 2 comments · Fixed by #6505
Closed

[Bug]: Opentelemetry missing span when using "-o yaml" option #6482

har-cpol opened this issue Sep 25, 2024 · 2 comments · Fixed by #6505
Assignees
Labels

Comments

@har-cpol
Copy link

Bug

Current behavior

When opentelemtry is enabled, and using "-o yaml" on any command, the last span generated references an unexisting parent span.

image

On the image:

  • Last span has parentId: '2469d70b49e96758'
  • No span has been exported with this spanId

In fact, there is no root span at all in this trace - so I expect that the root span is not correctly sent.

Expected behavior

All spans should be exported.
E.g. when we do not add the "-o yaml" option:

image

Here we do have the root span exported (last one: parentId is undefined)

Reproducible example

Any command that supports -o yaml:

  • OTEL_TRACES_EXPORTER=console garden get version -o yaml
  • OTEL_TRACES_EXPORTER=console garden get status -o yaml
  • OTEL_TRACES_EXPORTER=console garden get test result mytest -o yaml

Workaround

none

Suggested solution(s)

I suspect some span not correctly finished - but I'm not an expert on opentracing api JS

Additional context

  • There was no trace parent defined in my environment variables (no OTEL_TRACE_PARENT or TRACEPARENT env variable set)
  • On the example runs, I did not have the opentelemtry provider. I did try it before, and if I remember correctly it had same result

Your environment

  • OS: Fedora Linux
  • How I'm running Kubernetes: N/A

garden version

garden version: 0.13.38

@har-cpol har-cpol added the bug label Sep 25, 2024
@har-cpol
Copy link
Author

Update: Same issue occurs when using "-o json"

@eysi09
Copy link
Collaborator

eysi09 commented Sep 27, 2024

Thanks for the bug report and repro! We'll look into this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants