Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sync): use right arch of mutagen-agent binary in k8s-sync image #6465

Merged

Conversation

BraedonLeonard
Copy link
Contributor

What this PR does / why we need it:

The mutagen-agent binary in arm64 builds of k8s-sync (and therefore also k8s-util) were the binaries for amd64 instead. This updates the Dockerfile for k8s-sync to copy the correct binary for mutagen-agent.

@vvagaytsev
Copy link
Collaborator

@BraedonLeonard! Huge thanks for fixing this! 💯 Good catch! 👍
We have overlooked that. We'll review that PR very soon and will publish new images and a Garden release.

@vvagaytsev vvagaytsev changed the title fix: issue with k8s-sync's mutagen-agent binary being the wrong architecture fix(sync): use right mutagen-agent arch when build k8s-sync image Sep 24, 2024
@vvagaytsev vvagaytsev changed the title fix(sync): use right mutagen-agent arch when build k8s-sync image fix(sync): use right arch of mutagen-agent binary in k8s-sync image Sep 24, 2024
@vvagaytsev vvagaytsev added this pull request to the merge queue Sep 24, 2024
Merged via the queue into garden-io:main with commit 66e5a75 Sep 24, 2024
17 checks passed
@BraedonLeonard BraedonLeonard deleted the fix-k8s-sync-mutagen-agent-arch branch September 24, 2024 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants