fix(pulumi): fix process spawn machinery in Pulumi plugin #6377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thsig
force-pushed
the
fix-pulumi-proc-management
branch
from
74e8283 to
b17cb0f
Compare
vvagaytsev
force-pushed
the
fix-pulumi-proc-management
branch
from
52a1f9e to
e2deb8b
Compare
vvagaytsev
changed the title
twelvemo
approved these changes
Aug 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue(s) this PR fixes:
This PR simplifies the machinery of spawning oulumi CLI process and streaming its logs.
Now it uses
spawnAndWaitas many other external tools and supplies a logStream asstdoutandstderrto stream the logs to the Cloud.Which issue(s) this PR fixes:
Fixes #6322
Special notes for your reviewer: