Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE]: Support env variable to avoid running garden util hide-warning web-app #6303

Closed
bxsx opened this issue Jul 18, 2024 · 2 comments · Fixed by #6320
Closed

[FEATURE]: Support env variable to avoid running garden util hide-warning web-app #6303

bxsx opened this issue Jul 18, 2024 · 2 comments · Fixed by #6320
Assignees

Comments

@bxsx
Copy link
Contributor

bxsx commented Jul 18, 2024

Feature Request

Background / Motivation

My organization integrates Garden into CI pipeline, running it multiple times across various jobs. Since this workflow does not utilize the Garden Dashboard, it generates confusing output for our users:

09:18:39 ℹ garden-dashboard          → You are not logged in. To use the Garden dashboard, log in with the garden login command.
09:18:39 ℹ garden-dashboard          → Learn more at: https://docs.garden.io/using-garden/dashboard
09:18:39 
🌿 Log in with garden login to explore logs, past commands, and your dependency graph in the Garden dashboard.
Learn more at: https://docs.garden.io/using-garden/dashboard

→ Run garden util hide-warning web-app to disable this message.

Running garden util hide-warning web-app takes approximately 4 seconds, multiplied by the number of jobs where Garden is used. This accumulates to a significant time cost.

What should the user be able to do?

Setting up an environment variable equivalent to running the command above would be beneficial. Alternatively, it would be even better to completely disable the garden-dashboard component.

Why do they want to do this? What problem does it solve?

Execution time in our CI pipeline and developer experience by reducing confusing output.

Suggested Implementation(s)

Add the GARDEN_DISABLE_WEB_APP or GARDEN_DISABLE_DASHBOARD environment variable to hide the web-app warning.

If possible, completely disable the garden-dashboard component, including the output:

05:50:26 ℹ garden-dashboard          → You are not logged in. To use the Garden dashboard, log in with the garden login command.
05:50:26 ℹ garden-dashboard          → Learn more at: https://docs.garden.io/using-garden/dashboard

How important is this feature for you/your team?

Something between:
🌵 Not having this feature makes using Garden painful
🌹 It’s a nice to have, but nice things are nice 🙂

@vvagaytsev
Copy link
Collaborator

@bxsx we have implemented the flag called GARDEN_DISABLE_WEB_APP_WARN, it will be available in 0.13.36.

@bxsx
Copy link
Contributor Author

bxsx commented Jul 25, 2024

Thanks @vvagaytsev appreciate it :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants