feat: add building and publishing multi-platform images #6208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
twelvemo
changed the title
stefreak
reviewed
Jun 24, 2024
twelvemo
force-pushed
the
multi-platform-builds
branch
from
58dc7c3 to
c99f9b8
Compare
twelvemo
force-pushed
the
multi-platform-builds
branch
from
c99f9b8 to
5c97128
Compare
stefreak
previously approved these changes
Jun 24, 2024
vvagaytsev
approved these changes
Jun 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the config option and capability to trigger multi-platform builds. To allow publishing multi-platform images with the publish command, the publish command now uses
regctlwhenever possible. This allows us to copy newly tagged images directly without the need to pull them down to a local image store first. This is more performant, enables usage of the publish command in container based CIs and it is necessary in the context of multi-platform builds because most local image stores don't support storing multi-platform images.What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #3106
Special notes for your reviewer:
Uses regctl instead of skopeo, because it also has windows builds.