Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tool(kuztomize): support version 5.4.2 and use it by default #6144

Merged
merged 7 commits into from
Jun 5, 2024

Conversation

vvagaytsev
Copy link
Collaborator

@vvagaytsev vvagaytsev commented Jun 4, 2024

What this PR does / why we need it:

Adds support for the latest available major version of kustomize, and uses it by default in the code and Docker images.

Which issue(s) this PR fixes:

Fixes #6128

Special notes for your reviewer:

Multi-version tool lookup still requires some hard-coding and manual lookup-key construction. So, a few files should be modified at once despite there is no obvious connection between them.

This is how it's done in nother multi-version tools. It would be nice to refactor that approach, but nice things are nice :)
The refactoring can be done for all tools in separate PR(s).

@vvagaytsev vvagaytsev force-pushed the tool/support-kuztomize-5 branch from 2eb287c to ffc1bfa Compare June 4, 2024 16:16
@vvagaytsev vvagaytsev marked this pull request as ready for review June 4, 2024 16:47
@vvagaytsev vvagaytsev requested review from stefreak and twelvemo June 4, 2024 16:47
@vvagaytsev vvagaytsev force-pushed the tool/support-kuztomize-5 branch from 65468f4 to 3768594 Compare June 5, 2024 07:11
twelvemo
twelvemo previously approved these changes Jun 5, 2024
Copy link
Collaborator

@twelvemo twelvemo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!!

Copy link
Member

@stefreak stefreak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice 👍

@vvagaytsev vvagaytsev added this pull request to the merge queue Jun 5, 2024
Merged via the queue into main with commit 98a5504 Jun 5, 2024
41 checks passed
@vvagaytsev vvagaytsev deleted the tool/support-kuztomize-5 branch June 5, 2024 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update bundled kustomize tool version
3 participants