Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(images): add multi-platform images for garden deployed services #6072

Merged
merged 1 commit into from
May 24, 2024

Conversation

twelvemo
Copy link
Collaborator

@twelvemo twelvemo commented May 24, 2024

What this PR does / why we need it:

Adds multi-platform builds for all the garden deployed containers like buildkit, skopeo, k8s-sync, etc. This allows users to run garden on arm64 native kubernetes.

We can not use the publish command any longer to publish the images to dockerhub, since the docker-container buildx runner is not able to load the images in the default local docker image store. To facilitate this, we now always push to DockerHub when running garden build in this project, but with a dev tag. When running garden build --var publish=true we push them with the specified production tag in release_tag. This is a temporary workaround until we have properly integrated mutli-platform building into garden.

Also moves the images project from modules to actions ;-)

Which issue(s) this PR fixes:

Fixes #6088

Special notes for your reviewer:

@twelvemo twelvemo marked this pull request as ready for review May 24, 2024 14:00
@twelvemo twelvemo requested a review from vvagaytsev May 24, 2024 14:00
@twelvemo twelvemo force-pushed the multi-platform-images branch from 923b9d2 to fde8e6f Compare May 24, 2024 14:01
@vvagaytsev vvagaytsev changed the title feat(amd64): add multi-platform images for garden deployed services l… feat(amd64): add multi-platform images for garden deployed services May 24, 2024
@vvagaytsev
Copy link
Collaborator

Nice! Let's also explicitly define spec.publishId for all images.

@twelvemo
Copy link
Collaborator Author

Nice! Let's also explicitly define spec.publishId for all images.

We can't really use it yet, because we can't use the publish command, instead we have to run garden build --var publish=true. I wrote some more detailed explanations in the README.

@vvagaytsev vvagaytsev changed the title feat(amd64): add multi-platform images for garden deployed services feat(images): add multi-platform images for garden deployed services May 24, 2024
@vvagaytsev
Copy link
Collaborator

We can't really use it yet, because we can't use the publish command, instead we have to run garden build --var publish=true. I wrote some more detailed explanations in the README.

Ah, I see! Thank you :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update buildkit base images and dependencies
2 participants