fix(terraform): prevent deadlock by consuming stdout #6037
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nodejs spawn will cease to emit error or close events when stdout hasn't been consumed.
See also from official docs:
> By default, pipes for stdin, stdout, and stderr are established between the parent Node.js process and the spawned subprocess. These pipes have limited (and platform-specific) capacity. If the subprocess writes to stdout in excess of that limit without the output being captured, the subprocess blocks waiting for the pipe buffer to accept more data. This is identical to the behavior of pipes in the shell. Use the { stdio: 'ignore' } option if the output will not be consumed.
Source: https://nodejs.org/api/child_process.html#optionsstdio
We used to consume the stdout, but in the ESM PR (0f535dd) we accidentally removed the pipe to logStream which can cause deadlocks for terraform users.
vvagaytsev
approved these changes
May 14, 2024
|
@vvagaytsev thanks, hoping this is the sole culprit for the deadlocks we were seeing :) |
stefreak
added a commit
that referenced
this pull request
May 14, 2024
Follow-up on #6037 (This adds a missing test)
github-merge-queue bot
pushed a commit
that referenced
this pull request
May 14, 2024
Follow-up on #6037 (This adds a missing test)
|
regression test implemented in #6040 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nodejs spawn will cease to emit error or close events when stdout hasn't been consumed.
See also from official docs:
Source: https://nodejs.org/api/child_process.html#optionsstdio
We used to consume the stdout, but in the ESM PR (0f535dd) we accidentally removed the pipe to logStream which can cause deadlocks for terraform users.