Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(template): do not partially resolve function arg objects with special keys #5670

Merged
merged 1 commit into from
Jan 26, 2024

Conversation

edvald
Copy link
Collaborator

@edvald edvald commented Jan 26, 2024

This caused bad handling of e.g. $forEach objects in input variables for templated actions.

…cial keys

This caused bad handling of e.g. $forEach objects in input variables for
templated actions.
@edvald edvald requested a review from vvagaytsev January 26, 2024 10:37
Copy link
Collaborator

@vvagaytsev vvagaytsev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for fixing this! There were some tests failures, but those didn't look relevant. I rerun the CI pipeline.

@vvagaytsev vvagaytsev enabled auto-merge January 26, 2024 11:12
@vvagaytsev vvagaytsev added this pull request to the merge queue Jan 26, 2024
Merged via the queue into main with commit 5b7aea4 Jan 26, 2024
43 checks passed
@vvagaytsev vvagaytsev deleted the fix-partial-resolve-foreach branch January 26, 2024 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants