fix: copy test artifacts in interactive mode #5630
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vvagaytsev
force-pushed
the
fix/5629-copy-artifacts-in-interactive-tests
branch
2 times, most recently
from
4300ce7 to
a68191c
Compare
No need to declare `artifactsPath` as optional value. It is always defined in `RunActionParams` and `TestActionParams` types (via `CommonRunParams`). The function calls in the tests were changed to pass the required artifacts params.
Becasue the type is only used in that file.
vvagaytsev
force-pushed
the
fix/5629-copy-artifacts-in-interactive-tests
branch
from
a68191c to
ed693cb
Compare
thsig
requested changes
Jan 24, 2024
thsig
approved these changes
Jan 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #5629
Special notes for your reviewer: