fix(core): fix config error when using project.modules #5626
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TimBeyer
previously approved these changes
Jan 11, 2024
thsig
force-pushed
the
git-scan-mode-config-fixes
branch
from
95d3d90 to
953dc1d
Compare
Before this fix, an error would be thrown if using `scan.git.mode` and `module.include` or `module.exclude` together (since the Joi helper for renaming fields fails if there's already a value at the destination).
thsig
force-pushed
the
git-scan-mode-config-fixes
branch
from
953dc1d to
f4202fc
Compare
vvagaytsev
approved these changes
Jan 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Before this fix, an error would be thrown if using
scan.git.modeandmodule.includeormodule.excludetogether (since the Joi helper for renaming fields fails if there's already a value at the destination).