Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better sync mode warnings #5602

Closed
eysi09 opened this issue Dec 29, 2023 · 1 comment · Fixed by #5628
Closed

Better sync mode warnings #5602

eysi09 opened this issue Dec 29, 2023 · 1 comment · Fixed by #5628
Labels
devex Developer experience and ease of use. error-reporting quality Quality issues such as robustness, error handling, fault tolerance, etc ux

Comments

@eysi09
Copy link
Collaborator

eysi09 commented Dec 29, 2023

I'm getting the following warnings when deploying in sync mode:

Screenshot 2023-12-29 at 13 02 29

I think this needs improving:

  • Do we need to print a warning for "Using mode sync for Build postgres" and the rest? It's not clear what that means or why it should be a warning. In any case it'll be very noisy, in particular for large projects.
  • There's a typo in bythe
  • What does "Ignoring request" mean here? Note that these Deploy actions don't use this.mode in case that's relevant.
  • We should skip the new line, it doesn't look pretty when rendered like this, in particular when you have multiple warnings in a row.

To repro, deploy the platform project in sync mode.

@eysi09 eysi09 added bug ux devex Developer experience and ease of use. error-reporting quality Quality issues such as robustness, error handling, fault tolerance, etc and removed bug labels Dec 29, 2023
@eysi09
Copy link
Collaborator Author

eysi09 commented Jan 5, 2024

(I originally assigned @stefreak which is probably not the right process. So removing the assignment until we triage :))

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
devex Developer experience and ease of use. error-reporting quality Quality issues such as robustness, error handling, fault tolerance, etc ux
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants