improvement(logger): update some log lines after style changes #5507
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eysi09
force-pushed
the
log-color-fixes
branch
4 times, most recently
from
f51720b to
2ba6d83
Compare
The main issue was that the autocomplete suggestion was the same color as the actual text which has now been fixed. Beyond that, this replaces most calls to `accent` with `highlight` which is the better choice for these lines. It also changes the actual accent color to make it "pop" more. Before it was the same as the primary color. Finally I also used the chance to clean up some lines and ensure certain log lines aren't printed when in dev mode or running `noProject` commands.
eysi09
force-pushed
the
log-color-fixes
branch
from
2ba6d83 to
df46852
Compare
thsig
approved these changes
Dec 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
The main issue was that the autocomplete suggestion was the same color
as the actual text which has now been fixed.
Beyond that, this replaces most calls to
accentwithhighlightwhichis the better choice for these lines.
It also changes the actual accent color to make it "pop" more. Before it
was the same as the primary color.
Finally I also used the chance to clean up some lines and ensure certain
log lines aren't printed when in dev mode or running
noProjectcommands.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer: