improvement(logger): various tweaks to log lines #5452
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Namely: - Show provider name in the section for `ephemeral-kubernetes` - Add origin to K8s logs - Add origin to build util logs Note that adding `origin` to a given log context means that it'll be printed with the log line. So instead of: `deploy.api => Deployment/web: Started container web` We print: `deploy.api => [kubernetes] Deployment/web: Started container web`
vvagaytsev
approved these changes
Nov 21, 2023
shumailxyz
approved these changes
Nov 21, 2023
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Various tweaks to log lines. Namely:
ephemeral-kubernetesNote that adding
originto a given log context means that it'll be printed with the log line.So instead of:
deploy.api => Deployment/web: Started container webWe print:
deploy.api => [kubernetes] Deployment/web: Started container webWhich issue(s) this PR fixes:
Fixes #
Special notes for your reviewer: