fix: always resolve symlinks for the executable path in the self-updater #5352
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise `homebrew` but also other setups might fail since we will replace the symlink instead of the actual binary.
stefreak
approved these changes
Nov 6, 2023
stefreak
added a commit
that referenced
this pull request
Nov 6, 2023
This is to double down on making sure that self-update updates the correct path (See also #5352)
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 6, 2023
This is to double down on making sure that self-update updates the correct path (See also #5352)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Otherwise
homebrewbut also other setups might fail and corrupt data since we will replace the symlink instead of the actual binary.Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer: