improvement(k8s): remove old system garden and improve local-k8s startup time #5136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 26, 2023
vvagaytsev
force-pushed
the
improvement/remove-system-garden-new
branch
10 times, most recently
from
d5f04d3 to
ad1f9ea
Compare
stefreak
reviewed
Sep 28, 2023
vvagaytsev
force-pushed
the
improvement/remove-system-garden-new
branch
9 times, most recently
from
6683c68 to
43228a8
Compare
stefreak
reviewed
Oct 11, 2023
vvagaytsev
force-pushed
the
improvement/remove-system-garden-new
branch
7 times, most recently
from
27f8d76 to
3bf3258
Compare
For DRY, better readability snf maintainability.
vvagaytsev
force-pushed
the
improvement/remove-system-garden-new
branch
from
6d6f80f to
5bcaa29
Compare
To avoid circular imports.
vvagaytsev
force-pushed
the
improvement/remove-system-garden-new
branch
from
963271c to
2ea6202
Compare
stefreak
previously approved these changes
Nov 9, 2023
stefreak
approved these changes
Nov 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This and #5120 replace #4047.
This PR contains most part of the changes from #4047 - removal of the Garden system services.
Which issue(s) this PR fixes:
This PR enables us to merge #5120 which in turn fixes issues for windows users.
Special notes for your reviewer: