-
Notifications
You must be signed in to change notification settings - Fork 273
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
improvement(git): don't require Garden static
dir to be a Git repo
#5120
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great! 🥳
Can you remove git init
in the following places in this PR, to verify that garden really works without git in the static directory in our e2e tests:
garden/support/alpine.Dockerfile
Line 58 in 6c737a9
RUN cd /garden/static && git init Line 89 in 6c737a9
await exec("git", ["init"], { cwd: tmpStaticDir }) garden/support/buster.Dockerfile
Line 49 in 6c737a9
RUN cd /garden/static && git init
(Found those quickly scanning the code, but there might be more)
Good catch, @stefreak! Thank you so much! I'll double-check the rest pieces of the existing code. |
a686596
to
8352f78
Compare
8352f78
to
56e7fae
Compare
c89b356
to
dda945c
Compare
dda945c
to
036fd8f
Compare
6f1af5e
to
63d00c6
Compare
63d00c6
to
b7d3c9b
Compare
b7d3c9b
to
0d3ff1d
Compare
0d3ff1d
to
997ea6f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome 🥳
What this PR does / why we need it:
This is a subset of the changes from #4047. The original PR is quite old and requires some conflict resolution.
This PR brings a quick win to improve the usability of Garden.
Which issue(s) this PR fixes:
Fixes #2614
Fixes #4476
Fixes #4477
Fixes #5030
Special notes for your reviewer:
Depends on #5136