fix(k8s): allow null in spec.files for deploy config #4881
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Walther
reviewed
Jul 21, 2023
vvagaytsev
reviewed
Jul 21, 2023
vvagaytsev
approved these changes
Jul 24, 2023
|
I'm rather impatiently waiting for this fix to get released :) |
|
great. thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
ignore null values from spec.files in configure handler. Useful when some manifest files are to be used conditionally based on variable/template string resolution.
Which issue(s) this PR fixes:
Fixes #4878
Special notes for your reviewer: