fix: improved error messages when deps are missing #484
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Output a more informative error message when invalid/unknown dependencies are present in a module's configuration.
thsig
commented
Jan 25, 2019
eysi09
reviewed
Jan 28, 2019
eysi09
reviewed
Jan 28, 2019
|
In bb0fcf9, I changed the tests to more granularly test I didn't squash these changes right away, since it's probably easier to read through the changes addressing the PR comments this way. If there are no other comments, I'd like to squash this into one commit before merging. CC @edvald |
edvald
reviewed
Jan 28, 2019
edvald
reviewed
Jan 28, 2019
edvald
approved these changes
Jan 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Output a more informative error message when invalid/unknown
dependencies are present in a module's configuration.