Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0.12-Backport: fix(template-strings): do not apply helper functions on unresolved string #4710

Merged
merged 3 commits into from
Jun 26, 2023

Conversation

shumailxyz
Copy link
Contributor

What this PR does / why we need it:
cherrypicks #4692 into 0.12

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

@shumailxyz shumailxyz requested review from vvagaytsev and a team June 26, 2023 10:58
@shumailxyz shumailxyz marked this pull request as ready for review June 26, 2023 10:59
Copy link
Collaborator

@vvagaytsev vvagaytsev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some linting errors

@shumailxyz
Copy link
Contributor Author

@vvagaytsev Addressed the lint error.

@shumailxyz shumailxyz merged commit 8d51800 into 0.12 Jun 26, 2023
@shumailxyz shumailxyz deleted the backport-fix-template-str-unresolved branch June 26, 2023 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants