fix(cloud): properly handle dev delegation #4675
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a command is run with an option that results in it being run inside the `dev` command instead (e.g. `garden deploy --sync`), we now register the initial command session with Cloud as a `dev` command with the `--cmd` option set appropriately. This is useful for Cloud when listing command sessions created this way. For good measure, we include an explicit `isDevCommand` parameter with the session registration request to Cloud to make this setup more robust against future changes (instead of inferring whether the command is a `dev` command from the `commandInfo` map).
vvagaytsev
reviewed
Jun 21, 2023
vvagaytsev
reviewed
Jun 21, 2023
vvagaytsev
approved these changes
Jun 21, 2023
There was a problem hiding this comment.
@thsig thanks for fixing this! I've left a few non-blocking comments.
thsig
added a commit
that referenced
this pull request
Jun 22, 2023
This fixes some problems/limitations with the changes introduced in `4cdad7f502d88dd2b08d9bec663684b5359d87ce` (see #4675). Tests for the total flow will follow in a separate PR.
thsig
added a commit
that referenced
this pull request
Jun 22, 2023
This fixes some problems/limitations with the changes introduced in `4cdad7f502d88dd2b08d9bec663684b5359d87ce` (see #4675). Tests for the total flow will follow in a separate PR.
eysi09
pushed a commit
that referenced
this pull request
Jun 23, 2023
This fixes some problems/limitations with the changes introduced in `4cdad7f502d88dd2b08d9bec663684b5359d87ce` (see #4675). Tests for the total flow will follow in a separate PR.
ShankyJS
pushed a commit
that referenced
this pull request
Jul 10, 2023
This fixes some problems/limitations with the changes introduced in `4cdad7f502d88dd2b08d9bec663684b5359d87ce` (see #4675). Tests for the total flow will follow in a separate PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
When a command is run with an option that results in it being run inside the
devcommand instead (e.g.garden deploy --sync), we now register the initial command session with Cloud as adevcommand with the--cmdoption set appropriately. This is useful for Cloud when listing command sessions created this way.For good measure, we include an explicit
isDevCommandparameter with the session registration request to Cloud to make this setup more robust against future changes (instead of inferring whether the command is adevcommand from thecommandInfomap).Special notes for your reviewer:
I've verified that including the
isDevCommandparam in the registration request doesn't result in errors (it will be ignored by the API until implemented there). So there shouldn't be any compatibility problems in the meantime.