-
Notifications
You must be signed in to change notification settings - Fork 273
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(k8s): introduce new flag waitForJobs to wait for k8 jobs #4611
Conversation
I think this is sensible behavior but this is technically a breaking change. It's quite possible that there are usages which rely on the current behavior. You might argue that we should still do this given the state of transition to 0.13 across the user base, but it's debatable. An alternative would be to add a flag (e.g. If we do actually choose to make the breaking change, that would need to be clearly documented in 0.13 notes and migration guide etc. |
a96861f
to
211e597
Compare
27012da
to
6e524bb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
* feat(kubernetes): wait for kubernetes jobs * feat(k8s): introduce waitForJobs flag to control jobs behavior * chore: update docs * test: fix broken tests * chore: address pr comments
What this PR does / why we need it:
Introduces a new flag
waitForJobs
that can be set on thekubernetes
deploy to wait for the jobs to be finished.example:
Which issue(s) this PR fixes:
Fixes #4557
Special notes for your reviewer: