Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0.13: [Bug]: sync status not correct #4511

Closed
jalper opened this issue Jun 1, 2023 · 5 comments · Fixed by #4666
Closed

0.13: [Bug]: sync status not correct #4511

jalper opened this issue Jun 1, 2023 · 5 comments · Fixed by #4666
Assignees
Labels
0.13 bug priority:high High priority issue or feature

Comments

@jalper
Copy link
Contributor

jalper commented Jun 1, 2023

Garden Bonsai (0.13) Bug

Current Behavior

The new sync status command doesn't seem to be working as expected. When running it in a project with a whole bunch of syncs configured, after starting the syncs, they all show as "not-active". But if I run garden plugins kubernetes sync-status they all show as status: watching

Your environment

  • OS: macOS
  • How I'm running Kubernetes: GKE

% garden version
0.13.0

@jalper jalper added the 0.13 label Jun 1, 2023
@jalper jalper changed the title 0.13: [Bug]: Describe here 0.13: [Bug]: sync status not correct Jun 1, 2023
@eysi09 eysi09 added the bug label Jun 2, 2023
@eysi09 eysi09 moved this to Candidate in Core Weekly Jun 5, 2023
@Orzelius
Copy link
Contributor

Orzelius commented Jun 8, 2023

@jalper Thank you for reporting this. As there's a workaround we might prioritize a few other issues before this but we'll have a look in a couple of weeks.

@vvagaytsev vvagaytsev self-assigned this Jun 14, 2023
@vvagaytsev vvagaytsev moved this from Candidate to In Progress in Core Weekly Jun 14, 2023
@vvagaytsev
Copy link
Collaborator

vvagaytsev commented Jun 14, 2023

@jalper I wasn't able to reproduce this. Tried the vote project in the following way:

  1. Deployed it in sync mode gdev deploy --sync (gdev is the local alias. that points to the latest build of the main branch)
  2. Got to the dev console, tried sync status and got active
  3. Executed gdev plugins local-kubernetes sync-status from another terminal inside the vote example directory and got active syncs
  4. Exited the dev console with exit command -> syncs got stopped
  5. Executed gdev sync status and got non-active status as expected (because the syncs were stopped on exit form the dev console)
  6. Executed gdev plugins local-kubernetes sync-status from another terminal again and got no syncs.

Is it still reproducible? If it is, could you share a repro example, please?

@vvagaytsev vvagaytsev moved this from In Progress to Candidate in Core Weekly Jun 14, 2023
@vvagaytsev vvagaytsev moved this from Candidate to In Progress in Core Weekly Jun 15, 2023
@jalper
Copy link
Contributor Author

jalper commented Jun 16, 2023

@vvagaytsev definitely still an issue. When I try on our platform repo I get a mix of active and not-active when they should all be showing as active. I can try to put together a simpler repro next week if I have time.

@vvagaytsev vvagaytsev removed this from Core Weekly Jun 19, 2023
@eysi09
Copy link
Collaborator

eysi09 commented Jun 19, 2023

Yes, I can confirm I'm seeing the same.

To repro:

  1. In platform repo, run: garden deploy --sync
  2. Once it finishes deploying, run garden sync status and notice that it's not correct.

Also: The not-active status is logged with a the color green, it should be yellow.

Screenshot 2023-06-19 at 15 02 59

And the text that says something like: The api Deploy has 5 sync(s) configured should instead be The api Deploy action has 5 sync(s) configured (that is, adding action).

Perhaps we can fix that while we're at it.

@eysi09 eysi09 added the priority:high High priority issue or feature label Jun 19, 2023
@eysi09
Copy link
Collaborator

eysi09 commented Jun 19, 2023

I'm setting the priority to high on this one since the same information is displayed on the live page.

@vvagaytsev vvagaytsev moved this to Todo in Core Weekly Jun 19, 2023
@vvagaytsev vvagaytsev moved this from Todo to In Progress in Core Weekly Jun 20, 2023
@vvagaytsev vvagaytsev assigned thsig and unassigned vvagaytsev Jun 20, 2023
@vvagaytsev vvagaytsev moved this from In Progress to Done in Core Weekly Jun 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0.13 bug priority:high High priority issue or feature
Projects
No open projects
Status: Done
Development

Successfully merging a pull request may close this issue.

5 participants