fix: terraform module validation #4509
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Walther
force-pushed
the
terraform-module-validation-fixes
branch
from
9aa76ff to
f31d9eb
Compare
Walther
commented
Jun 1, 2023
| @@ -727,4 +727,442 @@ for (const terraformVersion of ["0.13.3", defaultTerraformVersion]) { | |||
| }) | |||
| }) | |||
| }) | |||
|
|
|||
| // TODO: re-enable after https://github.com/garden-io/garden/issues/4467 has been fixed | |||
| describe.skip("Terraform module type", () => { | |||
There was a problem hiding this comment.
This is a rather ugly copy of the test suite for Terraform action type with a couple of changes (e.g. using garden["moduleConfigs"]["tf"] instead of garden["actionConfigs"]["Deploy"]["tf"]).
These tests could be cleaned up a lot, but we should leave that for later.
These tests pass locally, and they make sure our module-to-action conversion logic works
Walther
force-pushed
the
terraform-module-validation-fixes
branch
from
38f5afc to
868a810
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #4508
Special notes for your reviewer:
We should make a release after merging this PR, as currently terraform module configurations will not work on Bonsai.
We should clean up these tests a bit some other day in a separate PR.