Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add get actions, builds, deploy cmd and update get runs, tests cmd #4449

Merged
merged 16 commits into from
Jun 2, 2023
Merged

feat: add get actions, builds, deploy cmd and update get runs, tests cmd #4449

merged 16 commits into from
Jun 2, 2023

Conversation

shumailxyz
Copy link
Contributor

@shumailxyz shumailxyz commented May 25, 2023 •
edited
Loading

What this PR does / why we need it:
Adds following commands:

  • get actions
  • get deploys
  • get builds

Updates following commands:

  • get tests
  • get runs

Which issue(s) this PR fixes:

Fixes #4218

Special notes for your reviewer:
There are breaking changes because the get tests and get runs commands now behave similar to the get actions command and have different output now.

However, if we want to avoid these breaking changes, i can revert changes to get tests & runs command.

@shumailxyz shumailxyz requested review from Orzelius and a team May 25, 2023 15:47
@shumailxyz shumailxyz changed the title feat(cmd): add get actions command WIP: add get actions command May 25, 2023
@shumailxyz shumailxyz force-pushed the feat/get-action-cmd branch from 5584367 to c079a6e Compare May 25, 2023 23:11
@shumailxyz shumailxyz removed the request for review from a team May 25, 2023 23:19
@Orzelius Orzelius removed their request for review May 26, 2023 08:55
@Orzelius
Copy link
Contributor

@shumailxyz if you request review on a wip branch I don't really know if it should we reviewed yet and I get emails about new commits.

@shumailxyz
Copy link
Contributor Author

@Orzelius My bad. I thought i had removed all reviewers.

@shumailxyz shumailxyz requested a review from a team May 26, 2023 17:15
@shumailxyz
Copy link
Contributor Author

@garden-io/core I'd like to request a pre-review of the WIP PR. Still need to add tests and get runs, get builds and get tests command however would be nice if you could already take a quick look. Thanks.

@shumailxyz shumailxyz force-pushed the feat/get-action-cmd branch 2 times, most recently from 7b7f84a to 3b0a11c Compare May 26, 2023 17:28
Orzelius
Orzelius reviewed May 29, 2023
View reviewed changes
Copy link
Contributor

@Orzelius Orzelius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

here's a few comments, hope they help. I take that the get deploy command is still under construction so I didn't dig in too deep, but it definitely should reuse more code from the get actions command.

core/src/commands/get/get-actions.ts Outdated Show resolved Hide resolved
core/src/commands/get/get-actions.ts Outdated Show resolved Hide resolved
core/src/commands/get/get-actions.ts Outdated Show resolved Hide resolved
core/src/commands/get/get-actions.ts Outdated Show resolved Hide resolved
core/src/commands/get/get-actions.ts Outdated Show resolved Hide resolved
core/src/commands/get/get-actions.ts Outdated Show resolved Hide resolved
core/src/commands/get/get-actions.ts Show resolved Hide resolved
core/src/commands/get/get-actions.ts Outdated Show resolved Hide resolved
@shumailxyz shumailxyz force-pushed the feat/get-action-cmd branch from 225fa4a to 2b0592d Compare May 31, 2023 12:05
@shumailxyz shumailxyz changed the title WIP: add get actions command add get actions command May 31, 2023
@shumailxyz shumailxyz marked this pull request as ready for review May 31, 2023 12:08
@shumailxyz shumailxyz requested review from a team and Orzelius May 31, 2023 12:08
@shumailxyz shumailxyz force-pushed the feat/get-action-cmd branch from 2b0592d to a8f9775 Compare May 31, 2023 12:30
@shumailxyz shumailxyz changed the title add get actions command feat: add get actions, builds, deploy cmd and update get runs, tests cmd May 31, 2023
@shumailxyz shumailxyz changed the title feat: add get actions, builds, deploy cmd and update get runs, tests cmd feat: add get actions, builds, deploy cmd May 31, 2023
@shumailxyz shumailxyz force-pushed the feat/get-action-cmd branch from 33f7a02 to a8f9775 Compare May 31, 2023 13:18
@shumailxyz shumailxyz changed the title feat: add get actions, builds, deploy cmd feat: add get actions, builds, deploy cmd and update get runs, tests cmd May 31, 2023
Orzelius
Orzelius reviewed May 31, 2023
View reviewed changes
Copy link
Contributor

@Orzelius Orzelius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there's a bit too much of repetition but other than that well done!

core/src/commands/get/get-actions.ts Outdated Show resolved Hide resolved
core/src/commands/get/get-builds.ts Outdated Show resolved Hide resolved
core/test/unit/src/commands/get/get-builds.ts Outdated Show resolved Hide resolved
@shumailxyz shumailxyz requested a review from Orzelius June 1, 2023 11:57
Orzelius
Orzelius previously approved these changes Jun 1, 2023
View reviewed changes
Copy link
Contributor

@Orzelius Orzelius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it!!

core/src/commands/get/get-builds.ts Show resolved Hide resolved
vvagaytsev
vvagaytsev requested changes Jun 1, 2023
View reviewed changes
Copy link
Collaborator

@vvagaytsev vvagaytsev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for implementing such a nice feature! 👍
I've left a few comments, please check :)

@shumailxyz shumailxyz requested a review from vvagaytsev June 1, 2023 22:00
vvagaytsev
vvagaytsev approved these changes Jun 2, 2023
View reviewed changes
Copy link
Collaborator

@vvagaytsev vvagaytsev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! 🚀

@shumailxyz shumailxyz merged commit 9b539a2 into main Jun 2, 2023
@shumailxyz shumailxyz deleted the feat/get-action-cmd branch June 2, 2023 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vvagaytsev vvagaytsev vvagaytsev approved these changes

@Orzelius Orzelius Orzelius left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

0.13: Rework the get commands
3 participants
@shumailxyz @Orzelius @vvagaytsev