chore: remove dns-lookup-cache #3389
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Wow good job on catching this, I was scratching my head pretty bad with this |
|
Great job, @Walther! Thank you! 🚀 |
Orzelius
approved these changes
Nov 29, 2022
vvagaytsev
approved these changes
Nov 29, 2022
|
FYI, the original reason for including that library was an issue for users running Rancher, bumping into dropped DNS requests and therefore connection issues with clusters. We should be aware of potential implications but I still agree that we should likely drop this library. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Fixes the regression in local Docker Desktop Kubernetes introduced in #3374 due to some adverse interaction with the DNS caching library we used.
Which issue(s) this PR fixes:
Replaces the need to revert the changes with #3387
Special notes for your reviewer:
The
dns-lookup-cachelibrary has its latest commit at nearly 3 years ago, so we should remove it anyway. If we absolutely need a DNS caching solution, we should figure out an alternative.