feat: allow to set no resource limits #3352
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the max value of memory or cpu under the container module is set to null, no resource limit will be set. If they are NOT set to anything at all (undefined), a default value is used.
vvagaytsev
reviewed
Nov 16, 2022
vvagaytsev
reviewed
Nov 16, 2022
vvagaytsev
requested changes
Nov 16, 2022
vvagaytsev
reviewed
Nov 16, 2022
vvagaytsev
approved these changes
Nov 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #3337
If the max value of memory or cpu under the container service is set to
null, no resource limit will be set. If they are NOT set to anything at
all (undefined), a default value is used like before.