Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE]: conditionally deploy services that have a dependency on another service when it is deployed #2759

Closed
tedchang77 opened this issue Feb 3, 2022 · 4 comments · Fixed by #4786

Comments

@tedchang77
Copy link

Feature Request

Background / Motivation

we have service-b that has a dependencies on service-a and also consumes an output from service a.. for example a dns entry. when we change service-a's outputs and re-deploy service-a, service-b has stale values causing it to not be able to connect to service-a. we need to then redeploy service-b to pick up the new output values.

What should the user be able to do?

automatically deploy services that have a dependency on the service that is being deployed. should be able to specify if you only want to deploy if the dependent service is already running or deploy if its missing.

Why do they want to do this? What problem does it solve?

not having to redeploy dependent services yourself

Suggested Implementation(s)

a couple of options added to the deploy command: --with-dependants and --update-only, the rormer willatter indicating that missing services should not be deployed.

How important is this feature for you/your team?

🌵 Not having this feature makes using Garden painful

@thsig thsig self-assigned this Feb 4, 2022
@stale
Copy link

stale bot commented Jun 12, 2022

This issue has been automatically marked as stale because it hasn't had any activity in 90 days. It will be closed in 14 days if no further activity occurs (e.g. changing labels, comments, commits, etc.). Please feel free to tag a maintainer and ask them to remove the label if you think it doesn't apply. Thank you for submitting this issue and helping make Garden a better product!

@stale stale bot added the stale Label that's automatically set by stalebot. Stale issues get closed after 14 days of inactivity. label Jun 12, 2022
@stale stale bot closed this as completed Jul 10, 2022
@thsig thsig reopened this Jul 11, 2022
@stale stale bot removed the stale Label that's automatically set by stalebot. Stale issues get closed after 14 days of inactivity. label Jul 11, 2022
@thsig thsig added the 0.13 label Jul 11, 2022
@stale
Copy link

stale bot commented Oct 16, 2022

This issue has been automatically marked as stale because it hasn't had any activity in 90 days. It will be closed in 14 days if no further activity occurs (e.g. changing labels, comments, commits, etc.). Please feel free to tag a maintainer and ask them to remove the label if you think it doesn't apply. Thank you for submitting this issue and helping make Garden a better product!

@stale stale bot added the stale Label that's automatically set by stalebot. Stale issues get closed after 14 days of inactivity. label Oct 16, 2022
@vvagaytsev vvagaytsev removed the stale Label that's automatically set by stalebot. Stale issues get closed after 14 days of inactivity. label Oct 20, 2022
@Walther Walther added this to 0.13 Jan 11, 2023
@stale
Copy link

stale bot commented May 22, 2023

This issue has been automatically marked as stale because it hasn't had any activity in 90 days. It will be closed in 14 days if no further activity occurs (e.g. changing labels, comments, commits, etc.). Please feel free to tag a maintainer and ask them to remove the label if you think it doesn't apply. Thank you for submitting this issue and helping make Garden a better product!

@stale stale bot added the stale Label that's automatically set by stalebot. Stale issues get closed after 14 days of inactivity. label May 22, 2023
@vvagaytsev vvagaytsev removed the stale Label that's automatically set by stalebot. Stale issues get closed after 14 days of inactivity. label May 24, 2023
@vvagaytsev vvagaytsev moved this to Candidate in Core Weekly Jul 6, 2023
@Orzelius Orzelius moved this from Candidate to In Progress in Core Weekly Jul 10, 2023
@Orzelius Orzelius self-assigned this Jul 11, 2023
@Orzelius
Copy link
Contributor

@tedchang77 sorry for taking so long with this, but it has been implemented via #4786.

For the --update-only flag could you perhaps create a separate issue if you still feel the need for it.

@shumailxyz shumailxyz moved this from In Progress to Done in Core Weekly Jul 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: No status
Status: Done
Development

Successfully merging a pull request may close this issue.

4 participants