fix: harbor error support #2619
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes to your CodeSee Architecture Map:View this PR diagram as an interactive map View more CodeSee Maps Legend |
|
Hi @mattpolzin! Thank you so much for the submitting a fix for this, and our apologies for the late reply. We've been on the road, travelling for KubeCon among other things so a bit behind schedule. The fix looks good to me. Any thoughts @edvald? |
edvald
approved these changes
Oct 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR addresses the issue I indirectly reported in this comment: #2418 (comment).
I am happy to open a new issue if that is desirable.
In short, the missing image error message given by Harbor used to happen to match the existing hard-coded check Garden performs. After updating the version of Harbor used for our internal image registry, my org started to see Garden fail to build images instead of recognizing that the image had just not been built at the current tag before.
Which issue(s) this PR fixes:
N/A
Special notes for your reviewer:
N/A