feat: allow passing additional tolerations to kaniko pods #2540
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edvald
requested changes
Aug 11, 2021
edvald
reviewed
Aug 11, 2021
edvald
approved these changes
Aug 11, 2021
dmytri
pushed a commit
to dmytri/garden
that referenced
this pull request
Aug 19, 2021
…2540) * feat: allow passing additional tolerations to kaniko pods * chore: add documentation for the additional kaniko tolerations * chore: add description for kaniko tolerations docs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Allows specifying additional tolerations that get passed to kaniko pods (both util and the builder pods).
A nice to have if stuff is run on, say, AKS - where any spot instance automatically has a taint that you need to tolerate in order to run anything.
Special notes for your reviewer: