Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE]: Respect the terminal color themes #2420

Closed
glennsarti opened this issue May 31, 2021 · 9 comments · Fixed by #5451
Closed

[FEATURE]: Respect the terminal color themes #2420

glennsarti opened this issue May 31, 2021 · 9 comments · Fixed by #5451
Labels
devex Developer experience and ease of use. feature request

Comments

@glennsarti
Copy link

Feature Request

Background / Motivation

Currently there doesn't appear to be a way to disable colourised output besides using a JSON/YAML output format. This can cause issues with terminals that don't fully support colourisation or font change e.g. italics. An example below

image

Admittedly the funny looking font is my terminal configuration (Default Windows Terminal with Cascadia Code Italics) but I cannot disable this "feature" in garden

It also causes issues in CI logging tools and spews out ANSI codes in log output.

What should the user be able to do?

There already exists a --log-level command line argument. I would like a --no-color argument as well to disable any fancy colouristation of output. Or perhaps an additional log-level of no-color which behave like basic but also have no colour.

This would also disable the ability to move the cursor easily using ANSI sequences so I'd expect this is an opt in setting.

Why do they want to do this? What problem does it solve?

If my terminal renders the "fancy" text incorrectly, I can quickly disable it so I can read the output of Garden

Suggested Implementation(s)

As above. either add --no-color or --log-level no-color

How important is this feature for you/your team?

🌵 Not having this feature makes using Garden painful

The rendered text is more difficult to read with a default install of Windows Terminal

@eysi09
Copy link
Collaborator

eysi09 commented Jun 1, 2021

Hi @glennsarti

That's a very good point and should be simple to fix. We'll look into this right away.

@eysi09 eysi09 self-assigned this Jun 1, 2021
@edvald
Copy link
Collaborator

edvald commented Jun 1, 2021

There is actually an undocumented way to do this with an environment variable: FORCE_COLOR=0. But the feature request is still definitely legit, we should have a canonical + documented way to do this.

@rogpeppe
Copy link

rogpeppe commented Sep 2, 2021

One standard way to do this is TERM=dumb. It would be great if that setting disabled all ANSI tty output.

@stale
Copy link

stale bot commented Jan 3, 2022

This issue has been automatically marked as stale because it hasn't had any activity in 90 days. It will be closed in 14 days if no further activity occurs (e.g. changing labels, comments, commits, etc.). Please feel free to tag a maintainer and ask them to remove the label if you think it doesn't apply. Thank you for submitting this issue and helping make Garden a better product!

@stale stale bot added the stale Label that's automatically set by stalebot. Stale issues get closed after 14 days of inactivity. label Jan 3, 2022
@stale stale bot closed this as completed Apr 16, 2022
@thsig thsig reopened this Apr 22, 2022
@stale stale bot removed the stale Label that's automatically set by stalebot. Stale issues get closed after 14 days of inactivity. label Apr 22, 2022
@stale
Copy link

stale bot commented Jul 31, 2022

This issue has been automatically marked as stale because it hasn't had any activity in 90 days. It will be closed in 14 days if no further activity occurs (e.g. changing labels, comments, commits, etc.). Please feel free to tag a maintainer and ask them to remove the label if you think it doesn't apply. Thank you for submitting this issue and helping make Garden a better product!

@stale stale bot added the stale Label that's automatically set by stalebot. Stale issues get closed after 14 days of inactivity. label Jul 31, 2022
@vvagaytsev vvagaytsev added devex Developer experience and ease of use. and removed stale Label that's automatically set by stalebot. Stale issues get closed after 14 days of inactivity. labels Sep 22, 2022
@stale
Copy link

stale bot commented Jan 7, 2023

This issue has been automatically marked as stale because it hasn't had any activity in 90 days. It will be closed in 14 days if no further activity occurs (e.g. changing labels, comments, commits, etc.). Please feel free to tag a maintainer and ask them to remove the label if you think it doesn't apply. Thank you for submitting this issue and helping make Garden a better product!

@stale stale bot added the stale Label that's automatically set by stalebot. Stale issues get closed after 14 days of inactivity. label Jan 7, 2023
@spenczar
Copy link

This remains an issue. Here's a screenshot of my very first time using garden:
Screen Shot 2023-01-17 at 10 36 49 AM

Pretty bad for a first-time user experience!

I would like to be able to set NO_COLOR=1 and get garden to use monochromatic output. See https://no-color.org/. The --no-color output or any of the other suggestions are fine too.

@stale stale bot removed the stale Label that's automatically set by stalebot. Stale issues get closed after 14 days of inactivity. label Jan 17, 2023
@stale
Copy link

stale bot commented May 21, 2023

This issue has been automatically marked as stale because it hasn't had any activity in 90 days. It will be closed in 14 days if no further activity occurs (e.g. changing labels, comments, commits, etc.). Please feel free to tag a maintainer and ask them to remove the label if you think it doesn't apply. Thank you for submitting this issue and helping make Garden a better product!

@stale stale bot added the stale Label that's automatically set by stalebot. Stale issues get closed after 14 days of inactivity. label May 21, 2023
@stale stale bot removed the stale Label that's automatically set by stalebot. Stale issues get closed after 14 days of inactivity. label Jun 7, 2023
@vvagaytsev vvagaytsev changed the title [FEATURE]: Ability to disable colorised output [FEATURE]: Respect the terminal color themes Jul 11, 2023
@eysi09
Copy link
Collaborator

eysi09 commented Nov 20, 2023

I'm terribly sorry for the way overdue reply.

Garden does indeed support the NO_COLOR environment variable (or rather the underlying library we use for rendering colors).

Is that not working for you?

My apologies, I misread this. We support FORCE_COLOR not NO_COLOR but we absolutely should. But for now FORCE_COLOR=0 would be the same as NO_COLOR=true

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
devex Developer experience and ease of use. feature request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants