feat(config): allow environment[].variables to reference top-level vars #1910
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Small bug that's failing the tests there, easy fix though, will push that in a bit |
Also fixes the issue where template strings were resolved in all environments, instead of just the selected one. Fixes #1814
edvald
force-pushed
the
variable-improvement
branch
from
ce67728 to
a504f20
Compare
edvald
force-pushed
the
variable-improvement
branch
from
a504f20 to
53999ae
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it easier to keep your project config neat and concise, allowing for some deduplication when environment configs repeat a lot of variables.
Also fixes the issue where template strings were resolved in all
environments, instead of just the selected one.
Fixes #1814