improvement(core): always require a namespace and simplify env config #1900
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edvald
changed the title
eysi09
reviewed
Jun 24, 2020
|
Yeah I see it, forgot to make a change in the K8s provider |
|
@edvald, anything I can help out with. Kind of blocked on the release atm. |
edvald
force-pushed
the
namespacing-change
branch
from
f0a7677 to
8697b9b
Compare
|
Just updated, let's see if tests pass. |
edvald
force-pushed
the
namespacing-change
branch
from
32c9d2c to
3e47924
Compare
We now always require a namespace for all environments, and make the
default simply "default". You can override the default namespace with
`environments[].defaultNamespace` as before.
This reduces code branching significantly, especially in the enterprise
UI, and simplifies our configuration as well.
BREAKING CHANGE:
The default namespace in the `kubernetes` provider is now
`<project name>.<environment namespace>` (previously it was just the
project name). Users need to override this to `"${project.name}"` if
they would like to revert to the previous default.
edvald
force-pushed
the
namespacing-change
branch
from
3e47924 to
1f35e52
Compare
edvald
force-pushed
the
namespacing-change
branch
from
1f35e52 to
c68ae28
Compare
edvald
added a commit
that referenced
this pull request
Jun 24, 2020
…#1900) * improvement(core): always require a namespace and simply env config We now always require a namespace for all environments, and make the default simply "default". You can override the default namespace with `environments[].defaultNamespace` as before. This reduces code branching significantly, especially in the enterprise UI, and simplifies our configuration as well. BREAKING CHANGE: The default namespace in the `kubernetes` provider is now `<project name>.<environment namespace>` (previously it was just the project name). Users need to override this to `"${project.name}"` if they would like to revert to the previous default.
This was referenced Dec 23, 2020
This was referenced Jan 12, 2022
This was referenced Feb 9, 2022
This was referenced Mar 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We now always require a namespace for all environments, and make the
default simply "default". You can override the default namespace with
environments[].defaultNamespaceas before.This reduces code branching significantly, especially in the enterprise
UI, and simplifies our configuration as well.
BREAKING CHANGE:
The default namespace in the
kubernetesprovider is now<project name>-<environment namespace>(previously it was just theproject name). Users need to override this to
"${project.name}"ifthey would like to revert to the previous default.