fix(k8s): ensure rendered helm chart contain runtime values #1882
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eysi09
approved these changes
Jun 18, 2020
edvald
force-pushed
the
fix-helm-render
branch
2 times, most recently
from
f40171e to
b82d758
Compare
The `helm template` command doesn't render values that need to be retrieved from the cluster. We therefore use `helm install|upgrade --dry-run` instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
The helm template command doesn't render values that need to be
retrieved from the cluster. We therefore use helm install|upgrade --dry-run instead.
Which issue(s) this PR fixes:
Fixes #1795
Reviewer notes:
Actually, I closed the prior issue prematurely @eysi09. This remains separate from the other fix I'll follow up with.