feat: add pull command #1681
Merged
feat: add pull command #1681
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What we've seen work is that with AWS you can set the cred helper on your local dockerconfig. It does mean extra local configuration step, so perhaps opting into using cluster credentials would be preferable? |
mitchfriedman
force-pushed
the
feature/add-pull-command
branch
3 times, most recently
from
5464891 to
636327b
Compare
swist
reviewed
Mar 19, 2020
mitchfriedman
force-pushed
the
feature/add-pull-command
branch
2 times, most recently
from
97b3348 to
a01322f
Compare
mitchfriedman
force-pushed
the
feature/add-pull-command
branch
from
a01322f to
5bfab26
Compare
|
Sorry @swist I missed your comment there a while back. I'm not sure we can use cluster credentials in a portable fashion. We should however definitely document the extra step for ECR auth. |
edvald
requested changes
Mar 20, 2020
mitchfriedman
force-pushed
the
feature/add-pull-command
branch
from
f9ca573 to
a7f7cc5
Compare
mitchfriedman
force-pushed
the
feature/add-pull-command
branch
4 times, most recently
from
60096d5 to
823a596
Compare
edvald
requested changes
Mar 23, 2020
garden-service/test/integ/src/plugins/kubernetes/commands/pull-image.ts
Outdated
Show resolved
Hide resolved
mitchfriedman
force-pushed
the
feature/add-pull-command
branch
3 times, most recently
from
2124531 to
aba71f9
Compare
mitchfriedman
force-pushed
the
feature/add-pull-command
branch
from
aba71f9 to
7bc460d
Compare
edvald
approved these changes
Mar 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Similarly to the
garden publishcommand, this adds agarden pullcommand that works for the kubernetes/container module types.A use case: a frontend engineer wants to run a local copy of an image but doesn't want to build the image (building takes longer than pulling down an image).
Which issue(s) this PR fixes:
Fixes # #1647
Special notes for your reviewer:
This doesn't work at the moment for external registries where auth is required that isn't currently supported (i.e. ecr with
credHelpers). We could perform a 2 step dance, however:I'm all open to other ideas that are perhaps simpler though.
@edvald @eysi09