feat(core): allow disabling modules, services, tests + tasks in configs #1515
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 15, 2020
thsig
previously approved these changes
Jan 20, 2020
This adds an optional `disabled` boolean field to all modules, and where applicable to service, task and test config schemas. The semantics are explained both in docs and unit tests, but they are as follows: - Disabling a module disables all services, tasks and tests within it. - A disabled module may still be built if it is a build dependency of another module. - Disabled services are never deployed and are ignored if listed as runtime dependencies. - Disabled tasks are never run and are ignored if listed as runtime dependencies. - Disabled tests are never run. - An error if throw if trying to explicitly run a service, task or test via `garden run ...`, unless the `--force` flag is set.
This adds a bit of future-proofing for schema changes to test and task results. If unknown fields are not allowed in task and test results, new fields stored on results generated by newer versions of the framework may cause errors when read by older versions which do not recognize the new fields.
davestephens
added a commit
to davestephens/garden
that referenced
this pull request
Jan 22, 2020
* 'master' of https://github.com/garden-io/garden: (32 commits) docs: added telemtry detail page fix: analytics make sure first event is flushed chore(ci): get minikube tests working for external contributors refactor(test): added tslint rule + removed js refactor(logger): add dataFormat to LogEntry fix(core): allow git URLs not ending in .git fix(test): improve error logging in e2e tests feat(core): allow disabling modules, services, tests + tasks in configs (garden-io#1515) fix(core): allow unknown in task & test results chore(github): phrasing for ranking in feat req templates chore(github): add feature request issue template improvement(core): detect rsync and ensure the version is recent enough chore(examples): update terraform example improvement(cli): use terminal-kit for better terminal compatibility chore(dashboard): lazy load modules + add error boundary docs: move provider and module type sections to top level docs: add documentation section for each provider docs: clarify version requirements for K8s and other dependencies chore: update stalebot config refactor: update Joi library ...
eysi09
pushed a commit
that referenced
this pull request
Jan 22, 2020
…gs (#1515) * feat(core): allow disabling modules, services, tests + tasks in configs This adds an optional `disabled` boolean field to all modules, and where applicable to service, task and test config schemas. The semantics are explained both in docs and unit tests, but they are as follows: - Disabling a module disables all services, tasks and tests within it. - A disabled module may still be built if it is a build dependency of another module. - Disabled services are never deployed and are ignored if listed as runtime dependencies. - Disabled tasks are never run and are ignored if listed as runtime dependencies. - Disabled tests are never run. - An error if throw if trying to explicitly run a service, task or test via `garden run ...`, unless the `--force` flag is set.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This adds an optional
disabledboolean field to all modules, andwhere applicable to service, task and test config schemas.
The semantics are explained both in docs and unit tests, but they are
as follows:
another module.
runtime dependencies.
runtime dependencies.
via
garden run ..., unless the--forceflag is set.Which issue(s) this PR fixes:
#1250
Special notes for your reviewer:
I've added a lot of tests here, but this is fairly difficult to cover. Please look for potential holes, both in terms of test coverage and functionality, and perhaps try testing manually if you're unsure if something works as expected.