Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manually running tests in interactive mode does not generate test artifacts #1475

Closed
stumpc opened this issue Jan 3, 2020 · 3 comments
Closed
Labels
bug priority:medium Medium priority issue or feature

Comments

@stumpc
Copy link

stumpc commented Jan 3, 2020

Bug

Current Behavior

When running garden tests in interactive mode (the default when using garden run test), the artifacts do not generate. Running tests with the interactive flag set to false (--interactive=false) allows the artifacts to generate.

Expected behavior

Artifacts should generate as defined whether or not garden run test is run with --interactive=false or --interactive=true

Reproducible example

Run defined garden tests manually using garden run test <module> <test-name>. Check your defined area in .garden/artifacts to find that no artifacts were generated.

Run defined garden tests manually using garden run test <module> <test-name> --interactive=false. Check your defined area in .garden/artifacts to find that the artifacts were generated this time.

Workaround

When manually running tests, use --interactive=false.

Suggested solution(s)

I personally think that artifacts should generate regardless of the --interactive flag status.

Your environment

garden version
0.10.16

kubectl version

Client Version: version.Info{Major:"1", Minor:"14", GitVersion:"v1.14.8", GitCommit:"211047e9a1922595eaa3a1127ed365e9299a6c23", GitTreeState:"clean", BuildDate:"2019-10-15T12:11:03Z", GoVersion:"go1.12.10", Compiler:"gc", Platform:"darwin/amd64"}
Server Version: version.Info{Major:"1", Minor:"14", GitVersion:"v1.14.8", GitCommit:"211047e9a1922595eaa3a1127ed365e9299a6c23", GitTreeState:"clean", BuildDate:"2019-10-15T12:02:12Z", GoVersion:"go1.12.10", Compiler:"gc", Platform:"linux/amd64"}

docker version
Docker version 19.03.5, build 633a0ea

@eysi09 eysi09 added bug priority:medium Medium priority issue or feature labels Jan 6, 2020
@stale
Copy link

stale bot commented Mar 6, 2020

This issue has been automatically marked as stale because it hasn't had any activity in 60 days. It will be closed in 14 days if no further activity occurs (e.g. changing labels, comments, commits, etc.). Please feel free to remove the label if you think it doesn't apply. Thank you for submitting this issue and helping make Garden a better product!

@stale stale bot added the stale Label that's automatically set by stalebot. Stale issues get closed after 14 days of inactivity. label Mar 6, 2020
@stale stale bot closed this as completed Mar 20, 2020
@edvald edvald reopened this Mar 20, 2020
@stale stale bot removed the stale Label that's automatically set by stalebot. Stale issues get closed after 14 days of inactivity. label Mar 20, 2020
@stale
Copy link

stale bot commented May 19, 2020

This issue has been automatically marked as stale because it hasn't had any activity in 60 days. It will be closed in 14 days if no further activity occurs (e.g. changing labels, comments, commits, etc.). Please feel free to tag a maintainer and ask them to remove the label if you think it doesn't apply. Thank you for submitting this issue and helping make Garden a better product!

@stale stale bot added the stale Label that's automatically set by stalebot. Stale issues get closed after 14 days of inactivity. label May 19, 2020
@eysi09 eysi09 removed the stale Label that's automatically set by stalebot. Stale issues get closed after 14 days of inactivity. label May 30, 2020
@eysi09
Copy link
Collaborator

eysi09 commented Jun 8, 2020

Closing as a duplicate of #1739

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug priority:medium Medium priority issue or feature
Projects
None yet
Development

No branches or pull requests

3 participants