improvement(analytics): improve the data collection #1438
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
solomonope
reviewed
Dec 16, 2019
10ko
force-pushed
the
analytics-v2
branch
2 times, most recently
from
6f0377c to
922fd1a
Compare
10ko
changed the title
edvald
requested changes
Dec 18, 2019
|
@edvald Added the changes you requested. |
edvald
reviewed
Dec 18, 2019
garden-service/src/task-graph.ts
Outdated
| } | ||
| // getBatchId() { | ||
| // return this.batchId | ||
| // } |
edvald
reviewed
Dec 18, 2019
examples/demo-project/garden.yml
Outdated
| @@ -7,6 +7,7 @@ environments: | |||
| providers: | |||
| - name: local-kubernetes | |||
| environments: [local] | |||
| buildMode: cluster-docker | |||
These changes bring some improvement what kind of data we track, how we track these events and the opt-in mechanism. Major changes: - Change analytics from optional to automatic opt-in - Add batchId to Task events - Rename taskName to taskType and added taskStatus - Add sessionId to events - Change projectId from uuid to hash of git origin - Turn on analytics for CI - Add project configuration aggregates
|
oops sorry about that, I removed those. |
edvald
approved these changes
Dec 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer: