feat: allow specifying tolerations for registry-proxy #1296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edvald
approved these changes
Oct 31, 2019
| .default("Equal") | ||
| .description(dedent` | ||
| Operator represents a key's relationship to the value. Valid operators are Exists and Equal. Defaults to | ||
| Equal. Exists is equivalent to wildcard for value, so that a pod can tolerate all taints of a |
There was a problem hiding this comment.
Would be nice to have quotes around the value names.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Enables users to set tolerations for the registry-proxy DaemonSet. From the docs:
Which issue(s) this PR fixes:
Fixes #1279
Special notes for your reviewer:
The description for the individual toleration fields and the validation rules are derived from the K8s API reference.