Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trigger a "config changed" event on changes to .garden/local-config.yaml #1082

Closed
eysi09 opened this issue Aug 6, 2019 · 2 comments
Closed
Labels
enhancement stale Label that's automatically set by stalebot. Stale issues get closed after 14 days of inactivity.

Comments

@eysi09
Copy link
Collaborator

eysi09 commented Aug 6, 2019

This is e.g. necessary for when users run a link command while Garden is running in watch mode in another process. Currently, the user would need to restart the watch process after running the link command for Garden to pick up the changes.

Notes on implementation

The link command updates the ./garden/local-config.yaml so we'd need watch that file for changes and trigger the `projectCnofig event.

The ./garden directory is excluded from the watcher so we need to handle the local-config.yaml file specifically.

Finally, we need to make sure the changes get picked up by the watcher instance. The instance is global and does not change even though a new instance of the Garden class is created, so we'd need to update it with the new paths (or reset it).

@eysi09
Copy link
Collaborator Author

eysi09 commented Aug 6, 2019

Alternatively we could also just have the link/unlink commands trigger the change and bypass having to watch the local-config.yaml file.

@stale
Copy link

stale bot commented Jan 15, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale Label that's automatically set by stalebot. Stale issues get closed after 14 days of inactivity. label Jan 15, 2020
@stale stale bot closed this as completed Jan 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement stale Label that's automatically set by stalebot. Stale issues get closed after 14 days of inactivity.
Projects
None yet
Development

No branches or pull requests

1 participant