Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

garden commands error if there's a broken symlink #1029

Closed
jmeickle opened this issue Jul 25, 2019 · 0 comments · Fixed by #1044
Closed

garden commands error if there's a broken symlink #1029

jmeickle opened this issue Jul 25, 2019 · 0 comments · Fixed by #1044
Assignees
Labels
Milestone

Comments

@jmeickle
Copy link

Bug

Current Behavior

Commands like garden scan fail with errors like this if there's a broken symlink:

ENOENT: no such file or directory, stat '/Users/eronarn/Code/qf/app/assets/javascripts/docs'

In my case:

[eronarn@ip-192-168-10-243 qf]$ ls -lath '/Users/eronarn/Code/qf/app/assets/javascripts/docs'
lrwxr-xr-x 1 eronarn staff 31 Nov 27  2018 /Users/eronarn/Code/qf/app/assets/javascripts/docs -> ../../../qdocs_build/_static/js

The intervening folders exist, but _static doesn't, so the symlink is (currently) broken.

Expected behavior

Local symlink issues don't prevent non-build commands, like scanning the project.

Suggested solution(s)

There should be a warning about the symlink, or potentially the module may fails building if a critical symlink can't be resolved; but project-level commands shouldn't fail on this condition.

Additional context

Usually one would expect symlinks to resolve, but not always; like in this case where I'm working in a repo where I haven't been building the docs. The application would work without the symlink and it's there for developer convenience.

Your environment

[eronarn@ip-192-168-10-243 qf]$ garden version
0.10.2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants