fix(vcs): garden.yml changes now only affect relevant module version #1009
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edvald
force-pushed
the
fix-multi-module-hash-issue
branch
from
723eb42 to
dbdf989
Compare
eysi09
reviewed
Jul 23, 2019
| @@ -148,6 +148,7 @@ export interface ModuleConfig | |||
|
|
|||
| outputs: PrimitiveMap | |||
| path: string | |||
| configPath?: string | |||
There was a problem hiding this comment.
Because we don't always have a config file, e.g. when plugins specify modules.
| @@ -96,6 +96,7 @@ export interface ProjectConfig { | |||
| kind: "Project", | |||
| name: string | |||
| path: string | |||
| configPath?: string | |||
There was a problem hiding this comment.
Same as above, shouldn't the config path be required?
| @@ -106,23 +106,25 @@ export class Watcher { | |||
| return (path: string) => { | |||
| this.log.debug(`Watcher: File ${path} ${type}`) | |||
|
|
|||
| const changedModules = modules.filter(m => m.version.files.includes(path)) | |||
| const changedModules = modules | |||
| .filter(m => m.version.files.includes(path) || m.configPath === path) | |||
There was a problem hiding this comment.
We're filtering on the configPath in at least three places. Should there be a generic function for this? Also feels like the type of thing one might forget.
There was a problem hiding this comment.
Each filter clause is different, so I can't see how we'd make it more generic. And re: forgetting—that's what the tests are for .)
eysi09
previously approved these changes
Jul 23, 2019
eysi09
dismissed
their stale review
All modules get re-built on changes to garden.yml
|
Looking into it |
Previously we were explicitly including the module config file in the module version file list. Now we ensure that it is _not_ included, which is the intended behavior after we started hashing the actual module config as part of the module version.
edvald
force-pushed
the
fix-multi-module-hash-issue
branch
from
b879b98 to
b8b8e99
Compare
edvald
changed the title
eysi09
approved these changes
Jul 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we were explicitly including the module config file in the
module version file list. Now we ensure that it is not included,
which is the intended behavior after we started hashing the actual
module config as part of the module version.