Skip to content
Permalink

Comparing changes

This is a direct comparison between two commits made in this repository or its related repositories. View the default comparison for this range or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: garden-io/garden
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 28a354c1b4b92a9df924024d3e8441252bb2fc48
Choose a base ref
..
head repository: garden-io/garden
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: d50350ec47a07c48c16e54f798d99f8ac998d06f
Choose a head ref
Showing with 1 addition and 6 deletions.
  1. +0 −5 core/src/plugins/container/publish.ts
  2. +1 −1 core/src/plugins/kubernetes/container/handlers.ts
5 changes: 0 additions & 5 deletions core/src/plugins/container/publish.ts
Original file line number Diff line number Diff line change
@@ -17,11 +17,6 @@ export const publishContainerBuild: BuildActionHandler<"publish", ContainerBuild
log,
tagOverride,
}) => {
let condition = true
if (condition) {
throw new Error("publishContainerBuild has been called")
}

const localImageId = action.getOutput("localImageId")
const remoteImageId = containerHelpers.getPublicImageId(action, tagOverride)

2 changes: 1 addition & 1 deletion core/src/plugins/kubernetes/container/handlers.ts
Original file line number Diff line number Diff line change
@@ -62,6 +62,7 @@ export function k8sGetContainerBuildActionOutputs({
action: Resolved<ContainerBuildAction>
}): ContainerBuildOutputs {
const localId = action.getSpec("localId")
const outputs = getContainerBuildActionOutputs(action)
const explicitImage = action.getSpec("publishId")
let imageId = localId
if (explicitImage) {
@@ -72,7 +73,6 @@ export function k8sGetContainerBuildActionOutputs({
imageId = containerHelpers.unparseImageId({ ...parsedImage, tag })
}

const outputs = getContainerBuildActionOutputs(action)
outputs.deploymentImageName = outputs["deployment-image-name"] = containerHelpers.getDeploymentImageName(
action.name,
imageId,