Skip to content

Commit

Permalink
improvement(core): experimental build stage implementation without rsync
Browse files Browse the repository at this point in the history
This implements the one-way build staging process entirely without
rsync. It's not trivial to get right, turns out, so for now this has
to be explicitly enabled by setting GARDEN_EXPERIMENT_BUILD_STAGE=true.

I've configured the e2e tests in CI to use the new mechanism, which
should help to surface issues, along with IRL usage testing.

We'll keep it that way until the next breaking release. Users who have
issues with the rsync-based implementation should give this a try and
by all means file issues and provide feedback.
  • Loading branch information
edvald authored and thsig committed Nov 25, 2020
1 parent 5d79d97 commit dcd8be7
Show file tree
Hide file tree
Showing 32 changed files with 2,266 additions and 618 deletions.
2 changes: 2 additions & 0 deletions .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -242,6 +242,8 @@ jobs:
description: The project environment to use
type: string
default: testing
environment:
GARDEN_EXPERIMENTAL_BUILD_STAGE: "true"
steps:
- checkout
- run: sudo apt-get update && sudo apt-get install rsync
Expand Down
5 changes: 4 additions & 1 deletion core/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@
"analytics-node": "3.3.0",
"ansi-escapes": "^4.3.1",
"archiver": "^4.0.1",
"async": "^3.2.0",
"async-exit-hook": "^2.0.1",
"async-lock": "^1.2.4",
"axios": "^0.19.2",
Expand Down Expand Up @@ -109,6 +110,7 @@
"path-is-inside": "^1.0.2",
"pluralize": "^8.0.0",
"proper-url-join": "^2.1.1",
"readdir-enhanced": "^6.0.4",
"recursive-readdir": "^2.2.2",
"request": "^2.88.2",
"request-promise": "^4.2.5",
Expand Down Expand Up @@ -144,6 +146,7 @@
"@commitlint/config-conventional": "^8.3.4",
"@google-cloud/kms": "^2.0.0",
"@types/analytics-node": "^3.1.3",
"@types/async": "^3.2.4",
"@types/async-lock": "^1.1.2",
"@types/bluebird": "^3.5.32",
"@types/chai": "^4.2.11",
Expand Down Expand Up @@ -249,4 +252,4 @@
]
},
"gitHead": "b0647221a4d2ff06952bae58000b104215aed922"
}
}
252 changes: 0 additions & 252 deletions core/src/build-dir.ts

This file was deleted.

Loading

0 comments on commit dcd8be7

Please sign in to comment.