Skip to content

Commit

Permalink
fix: regression after splitting up GardenContext
Browse files Browse the repository at this point in the history
  • Loading branch information
eysi09 committed Apr 13, 2018
1 parent d86f916 commit bbb6db5
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 2 deletions.
8 changes: 7 additions & 1 deletion src/plugins/kubernetes/namespace.ts
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,13 @@ import {
import { GARDEN_GLOBAL_SYSTEM_NAMESPACE } from "./system-global"

export async function namespaceReady(namespace: string) {
const ns = await apiGetOrNull(coreApi().namespaces, namespace)
/**
* This is an issue with kubernetes-client where it fetches all namespaces instead of the requested one.
* Is fixed in v4.0.0. See https://github.com/godaddy/kubernetes-client/issues/187 and
* https://github.com/godaddy/kubernetes-client/pull/190
*/
const allNamespaces = await apiGetOrNull(coreApi().namespaces, namespace)
const ns = allNamespaces.items.find(n => n.metadata.name === namespace)
return ns && ns.status.phase === "Active"
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -167,7 +167,7 @@ spec:
type: NodePort
ports:
- port: 443
nodePort: 3200
nodePort: 32005
targetPort: 8443
selector:
k8s-app: kubernetes-dashboard

0 comments on commit bbb6db5

Please sign in to comment.