Skip to content

Commit

Permalink
refactor(core): only set config names once in resolveModuleConfigs
Browse files Browse the repository at this point in the history
Assuming this was a rebase error.
  • Loading branch information
eysi09 committed Sep 29, 2019
1 parent 65e4d0f commit baabb98
Showing 1 changed file with 0 additions and 15 deletions.
15 changes: 0 additions & 15 deletions garden-service/src/garden.ts
Original file line number Diff line number Diff line change
Expand Up @@ -637,21 +637,6 @@ export class Garden {
const ctx = await this.getPluginContext(provider)
config = await configureHandler({ ctx, moduleConfig: config, log: this.log })

if (config.plugin) {
// Make sure nested entities in plugin modules are scoped by name
for (const serviceConfig of config.serviceConfigs) {
serviceConfig.name = `${config.plugin}--${serviceConfig.name}`
}

for (const taskConfig of config.taskConfigs) {
taskConfig.name = `${config.plugin}--${taskConfig.name}`
}

for (const testConfig of config.testConfigs) {
testConfig.name = `${config.plugin}--${testConfig.name}`
}
}

// FIXME: We should be able to avoid this
config.name = getModuleKey(config.name, config.plugin)

Expand Down

0 comments on commit baabb98

Please sign in to comment.