fix(cli): avoid crash with circular references in error details

garden-io · Apr 4, 2019 · 92b31c0 · 92b31c0
1 parent 35ad3df
commit 92b31c0
Showing 1 changed file with 7 additions and 2 deletions.
diff --git a/garden-service/src/logger/renderers.ts b/garden-service/src/logger/renderers.ts
@@ -96,8 +96,13 @@ export function renderError(entry: LogEntry) {
         acc[kebabCase(key)] = val
         return acc
       }, {})
-      const yamlDetail = yaml.safeDump(kebabCasedDetail, { noRefs: true, skipInvalid: true })
-      out += `\nError Details:\n${yamlDetail}`
+
+      try {
+        const yamlDetail = yaml.safeDump(kebabCasedDetail, { noRefs: true, skipInvalid: true })
+        out += `\nError Details:\n${yamlDetail}`
+      } catch (err) {
+        out += `\nUnable to render error details:\n${err.message}`
+      }
     }
     return out
   }