From 85f31f9421f173b9e86a2b9e85a3205164208123 Mon Sep 17 00:00:00 2001 From: Thorarinn Sigurdsson Date: Fri, 30 Nov 2018 08:37:00 +0100 Subject: [PATCH] fix: make dev cmd consistent with deploy cmd Fixes https://github.com/garden-io/garden/issues/388. Don't return a singleton build task by default in the dev command. This makes the dev command's behavior more consistent with the deploy command in watch mode. --- garden-service/src/commands/dev.ts | 9 +-------- 1 file changed, 1 insertion(+), 8 deletions(-) diff --git a/garden-service/src/commands/dev.ts b/garden-service/src/commands/dev.ts index a1bcbbcc77..a7d16aed31 100644 --- a/garden-service/src/commands/dev.ts +++ b/garden-service/src/commands/dev.ts @@ -15,7 +15,6 @@ import { flatten } from "lodash" import moment = require("moment") import { join } from "path" -import { BuildTask } from "../tasks/build" import { BaseTask } from "../tasks/base" import { hotReloadAndLog, validateHotReloadOpt } from "./helpers" import { getTasksForModule, getHotReloadModuleNames } from "../tasks/helpers" @@ -110,7 +109,7 @@ export class DevCommand extends Command { const testTasks: BaseTask[] = flatten(await Bluebird.map( testModules, m => getTestTasks({ garden, log, module: m }))) - const tasks = testTasks.concat(await getTasksForModule({ + return testTasks.concat(await getTasksForModule({ garden, log, module, @@ -120,12 +119,6 @@ export class DevCommand extends Command { forceBuild: watch, includeDependants: watch, })) - - if (tasks.length === 0) { - return [new BuildTask({ garden, log, module, force: watch })] - } else { - return tasks - } } }